Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility with SDL 2.0.10 for Ubuntu Focal #273

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Fix compatibility with SDL 2.0.10 for Ubuntu Focal #273

merged 1 commit into from
Oct 23, 2023

Conversation

meyerj
Copy link

@meyerj meyerj commented Oct 19, 2023

Resolves #267.

SDL_GameControllerHasRumble() was introduced in SDL 2.0.18 only (libsdl-org/SDL#4943).

@meyerj
Fix compatibility with SDL versions below 2.0.18
ba5d91c 
SDL_GameControllerHasRumble() was introduced in SDL 2.0.18 only (libsdl-org/SDL#4943).

Signed-off-by: Johannes Meyer <[email protected]>
clalancette
clalancette approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. Thanks for the patch!

@clalancette clalancette merged commit a5adee5 into ros-drivers:ros2 Oct 23, 2023
3 checks passed
This was referenced Oct 23, 2023
Closed
Closed
@meyerj meyerj deleted the fix/compatibility-with-sdl-2.0.10 branch October 23, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meyerj @clalancette